I think that suggestion is great in many circumstances. In larger PORO (or components), I find that using an attr_reader or attr_accessor can break the readability of the code. Simply because an instance variable, at a glance will be something that you know is coming from an external source from the perspective of the object. But any local variables are likely a private method or something similar.